xiangfu0 commented on PR #11672: URL: https://github.com/apache/pinot/pull/11672#issuecomment-1746373423
> > here are too many CI checks, can we try to reduce the number of tests? > > Sure, we need to discuss which ones we want to have. > > My recommendation right now is: > > 1. Java 11, skip bytebuffers false > 2. Java 17, skip bytebuffers false > 3. Java 21, skip bytebuffers false > 4. Java 21, skip bytebuffers true > > Java 11 with skipbuffers true should also be enable, but given it doesn't pass the tests right now, we need to skip it. What do you think? I think we can just test the default byteBuffer usage. For the others, if you have good test coverage, we can just write a test suite for testing to ensure the coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
