gortiz commented on PR #11672: URL: https://github.com/apache/pinot/pull/11672#issuecomment-1746381234
> I think we can just test the default byteBuffer usage. > For the others, if you have good tests, we can just write a test suite for testing different behaviors to ensure the coverage. `PinotDataBufferTest` already does that... but as is proven by this PR, it is not enough. There are some particularities in LArray that are not tested there. Given the importance of the buffer library (it may imply incorrect results or data corruption), I think it is worth it to have at least one execution where the unsafe buffer is tested. But we can skip it if you think it is not necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
