xiangfu0 commented on code in PR #11672:
URL: https://github.com/apache/pinot/pull/11672#discussion_r1358918958
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/PinotDataBuffer.java:
##########
@@ -152,17 +153,22 @@ public static PinotBufferFactory getFactory() {
}
public static PinotBufferFactory createDefaultFactory() {
- return createDefaultFactory(true);
+ String skipBbEnvValue = System.getenv(SKIP_BYTEBUFFER_ENV);
+ boolean prioritizeByteBuffer = !Boolean.parseBoolean(skipBbEnvValue);
Review Comment:
Can we just parse this once?
Make `prioritizeByteBuffer` a static value is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
