yashmayya commented on code in PR #12992:
URL: https://github.com/apache/pinot/pull/12992#discussion_r1576609447
##########
pinot-common/pom.xml:
##########
@@ -62,6 +62,27 @@
<artifactId>protobuf-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
Review Comment:
Yeah, I assumed that https://github.com/apache/pinot/pull/11670 introduced
the `pluginManagement` in this POM for the JDK 21 build profile (i.e., to avoid
running this plugin's goal with Java 21)? Also we're overriding the plugin
configuration here (for the separate excludes I presume), so it's not like we
can simply define it here without the configuration right?
Edit: We're still leveraging the plugin management from the parent POM since
we aren't redefining the plugin version or executions here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
