gortiz commented on code in PR #12992:
URL: https://github.com/apache/pinot/pull/12992#discussion_r1579160738
##########
pinot-common/pom.xml:
##########
@@ -62,6 +62,27 @@
<artifactId>protobuf-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
Review Comment:
> What I meant is that we should be able to put the excludes in the root pom
where there is another configuration for this plug-in, then we keep a single
configuration for this plug-in for easier management
I think that is a bad practice. This is the project that knows which files
should be ignored. In case other projects want to do the same we don't want to
merge that information.
The pom project should specify the plugin version and the _common_
configuration. Configuration specific to each sub-project should be configured
by each sub-project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
