yashmayya commented on code in PR #12992:
URL: https://github.com/apache/pinot/pull/12992#discussion_r1578801113
##########
pom.xml:
##########
@@ -1625,7 +1611,6 @@
<version>2.43.0</version>
<executions>
<execution>
- <phase>verify</phase>
Review Comment:
This isn't required because `spotless:check` is already bound to Maven's
`verify` phase by default (see
https://github.com/diffplug/spotless/blob/main/plugin-maven/README.md#binding-to-maven-phase).
##########
pinot-common/pom.xml:
##########
@@ -62,6 +62,27 @@
<artifactId>protobuf-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
Review Comment:
Ah okay, I've made that change. Not sure why it was like that earlier -
perhaps to avoid adding child module specific excludes in the parent POM? Looks
like it was added in https://github.com/apache/pinot/pull/8427/files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
