xiangfu0 commented on code in PR #13165:
URL: https://github.com/apache/pinot/pull/13165#discussion_r1604252733
##########
helm/pinot/values.yaml:
##########
@@ -52,6 +52,9 @@ securityContext: {}
probes:
initialDelaySeconds: 60
periodSeconds: 10
+ failureThreshold: 1
Review Comment:
This default threshold seems to be easier met when there is a system or
network glitch.
Shall we make it as 10?
##########
helm/pinot/templates/broker/statefulset.yaml:
##########
@@ -93,6 +93,9 @@ spec:
livenessProbe:
Review Comment:
since there are multiple probes, shall we change probe configs to
`Values.probes.livenessProbe.failureThreshold` /
`Values.probes.readinessProbe.failureThreshold` which default to
`Values.probes.failureThreshold` but allow customization if needed.
E.g. in StarTree deployment we see that for many environments we need to
customize startupProbe and livenessProbe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
