piby180 commented on PR #13165:
URL: https://github.com/apache/pinot/pull/13165#issuecomment-2117494643
@abhioncbr Thanks for taking time to work on this PR
@xiangfu0 thanks for the review.
However, the changes are still not enough for us. For us, the server pods
takes longer time to restart as compared to controller or minion pods. Hence
we do need to customize different probe settings for different components.
Especially for server pods, I need longer initialDelaySeconds and higher
failureThreshold at least for startup probe.
I would suggest the following:
```
// Instead of
initialDelaySeconds: {{ .Values.probes.initialDelaySeconds }}
// we should use
initialDelaySeconds:
{{.Values.controller.probes.livenessProbe.initialDelaySeconds | default
.Values.probes.initialDelaySeconds }}
```
This would be backwards compatible and provides full customization of all
settings. I know it is a bit tedius but it will provide us more flexibility to
optimize probes as per our environment :)
Feel free to ping me for any additional information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
