abhioncbr commented on code in PR #13165:
URL: https://github.com/apache/pinot/pull/13165#discussion_r1605659018
##########
helm/pinot/templates/minion-stateless/deployment.yaml:
##########
@@ -79,20 +79,37 @@ spec:
{{- end }}
{{- if .Values.minionStateless.probes.livenessEnabled }}
livenessProbe:
- initialDelaySeconds: {{ .Values.probes.initialDelaySeconds }}
+ initialDelaySeconds: {{
.Values.minionStateless.probes.liveness.initialDelaySeconds | default
.Values.probes.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.periodSeconds }}
+ failureThreshold: {{
.Values.minionStateless.probes.liveness.failureThreshold | default
.Values.probes.failureThreshold }}
+ successThreshold: {{ .Values.probes.successThreshold }}
+ timeoutSeconds: {{
.Values.minionStateless.probes.liveness.timeoutSeconds | default
.Values.probes.timeoutSeconds }}
httpGet:
path: {{ .Values.minionStateless.probes.endpoint }}
port: {{ .Values.minionStateless.service.port }}
{{- end }}
{{- if .Values.minionStateless.probes.readinessEnabled }}
readinessProbe:
- initialDelaySeconds: {{ .Values.probes.initialDelaySeconds }}
+ initialDelaySeconds: {{
.Values.minionStateless.probes.readiness.initialDelaySeconds | default
.Values.probes.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.periodSeconds }}
+ failureThreshold: {{
.Values.minionStateless.probes.readiness.failureThreshold | default
.Values.probes.failureThreshold }}
+ successThreshold: {{ .Values.probes.successThreshold }}
Review Comment:
I think `successThreshold` and `periodSeconds` don't need to be separate
based on component. For complete customization perspective we can do the same
but otherwise IMO, value is always going to be same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
