deemoliu commented on code in PR #13579:
URL: https://github.com/apache/pinot/pull/13579#discussion_r1674703351
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -432,30 +432,11 @@ protected void doAddSegment(ImmutableSegmentImpl segment)
{
String segmentName = segment.getSegmentName();
_logger.info("Adding segment: {}, current primary key count: {}",
segmentName, getNumPrimaryKeys());
long startTimeMs = System.currentTimeMillis();
-
- MutableRoaringBitmap validDocIds;
- if (_enableSnapshot) {
- validDocIds = segment.loadValidDocIdsFromSnapshot();
Review Comment:
can you please check if metadata TTL is enabled. i don't think we can remove
it if metadata TTL is enabled.
by removing these lines, when metadataTTL is enabled but preloading is not
enabled, we will have missing valid docIDs for historical segments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
