tibrewalpratik17 commented on code in PR #13579:
URL: https://github.com/apache/pinot/pull/13579#discussion_r1675492201
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -432,30 +432,11 @@ protected void doAddSegment(ImmutableSegmentImpl segment)
{
String segmentName = segment.getSegmentName();
_logger.info("Adding segment: {}, current primary key count: {}",
segmentName, getNumPrimaryKeys());
long startTimeMs = System.currentTimeMillis();
-
- MutableRoaringBitmap validDocIds;
- if (_enableSnapshot) {
- validDocIds = segment.loadValidDocIdsFromSnapshot();
Review Comment:
@deemoliu this method is not called at all in case the segment is out of
metadataTTL window. Ref:
https://github.com/apache/pinot/blob/dacc6d06907c44e83721454f1090e5f00c824f15/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java#L389-L406
We are returning in the caller method above for out of metadataTTL segments.
This flow affects the segments which are in metadataTTL window, in that case
it is okay to read the whole segment and not just from snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
