deemoliu commented on code in PR #13579:
URL: https://github.com/apache/pinot/pull/13579#discussion_r1678200981
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -432,30 +432,11 @@ protected void doAddSegment(ImmutableSegmentImpl segment)
{
String segmentName = segment.getSegmentName();
_logger.info("Adding segment: {}, current primary key count: {}",
segmentName, getNumPrimaryKeys());
long startTimeMs = System.currentTimeMillis();
-
- MutableRoaringBitmap validDocIds;
- if (_enableSnapshot) {
- validDocIds = segment.loadValidDocIdsFromSnapshot();
Review Comment:
I recall the prior discussions with @klsince and @Jackie-Jiang, upsert TTL
(metadataTTL) snapshotting supposed to be atomic at partition level instead of
segment level. We need to avoid keeping some snapshot meanwhile delete the
other snapshots for the same partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
