9aman commented on code in PR #14460:
URL: https://github.com/apache/pinot/pull/14460#discussion_r1843166842
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -485,8 +485,7 @@ private void setUpPinotController() {
// Helix resource manager must be started in order to create
PinotLLCRealtimeSegmentManager
LOGGER.info("Starting realtime segment manager");
- _pinotLLCRealtimeSegmentManager =
- new PinotLLCRealtimeSegmentManager(_helixResourceManager, _config,
_controllerMetrics);
+ _pinotLLCRealtimeSegmentManager = createPinotLLCRealtimeSegmentManager();
Review Comment:
These changes in the ControllerStarter have been added to easily override
two crucial classes:
PinotLLCRealtimeSegmentManager and RealtimeSegmentValidationManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
