mcvsubbu commented on code in PR #14460:
URL: https://github.com/apache/pinot/pull/14460#discussion_r1857087110
##########
pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java:
##########
@@ -242,6 +244,7 @@ public static class Params {
private long _memoryUsedBytes;
private long _segmentSizeBytes;
private String _streamPartitionMsgOffset;
+ private boolean _pauselessConsumptionEnabled;
Review Comment:
Instead of changing the existing protocol, please add a new controller
endpoint that is called from the server when it needs the idealstate modified
before segment upload.
This will avoid a lot of `if pauselessEnabled` statements in the code path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
