9aman commented on code in PR #14460:
URL: https://github.com/apache/pinot/pull/14460#discussion_r1843172802
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java:
##########
@@ -116,28 +116,36 @@ protected StreamPartitionMsgOffsetFactory
getStreamPartitionMsgOffsetFactory(LLC
return
StreamConsumerFactoryProvider.create(streamConfig).createStreamMsgOffsetFactory();
}
- private SegmentCompletionFSM lookupOrCreateFsm(LLCSegmentName
llcSegmentName, String msgType) {
- return _fsmMap.computeIfAbsent(llcSegmentName.getSegmentName(), k ->
createFsm(llcSegmentName, msgType));
+ private SegmentCompletionFSM lookupOrCreateFsm(LLCSegmentName
llcSegmentName, String msgType,
+ boolean pauselessConsumptionEnabled) {
+ return _fsmMap.computeIfAbsent(llcSegmentName.getSegmentName(),
+ k -> createFsm(llcSegmentName, msgType, pauselessConsumptionEnabled));
}
- private SegmentCompletionFSM createFsm(LLCSegmentName llcSegmentName, String
msgType) {
+ private SegmentCompletionFSM createFsm(LLCSegmentName llcSegmentName, String
msgType,
+ boolean pauselessConsumptionEnabled) {
String realtimeTableName =
TableNameBuilder.REALTIME.tableNameWithType(llcSegmentName.getTableName());
String segmentName = llcSegmentName.getSegmentName();
SegmentZKMetadata segmentMetadata =
_segmentManager.getSegmentZKMetadata(realtimeTableName, segmentName, null);
Preconditions.checkState(segmentMetadata != null, "Failed to find ZK
metadata for segment: %s", segmentName);
SegmentCompletionFSM fsm;
- if (segmentMetadata.getStatus() ==
CommonConstants.Segment.Realtime.Status.DONE) {
+ // TODO (akkhanch): introducing this as the first step of the segment
metadata might have succeeded. We don't
+ // want the server to try indefinitely, rather we would rely on the
validation manager to complete the remaining
+ // steps.
+ if (segmentMetadata.getStatus() ==
CommonConstants.Segment.Realtime.Status.DONE
Review Comment:
This has been added to prevent servers from retrying indefinitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
