gortiz commented on code in PR #14690:
URL: https://github.com/apache/pinot/pull/14690#discussion_r1898442018
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -91,9 +91,10 @@ public abstract class BaseClusterIntegrationTest extends
ClusterTest {
protected static final List<String> DEFAULT_NO_DICTIONARY_COLUMNS =
Arrays.asList("ActualElapsedTime", "ArrDelay", "DepDelay", "CRSDepTime");
protected static final String DEFAULT_SORTED_COLUMN = "Carrier";
- protected static final List<String> DEFAULT_INVERTED_INDEX_COLUMNS =
Arrays.asList("FlightNum", "Origin", "Quarter");
- private static final List<String> DEFAULT_BLOOM_FILTER_COLUMNS =
Arrays.asList("FlightNum", "Origin");
- private static final List<String> DEFAULT_RANGE_INDEX_COLUMNS =
Collections.singletonList("Origin");
+ protected static final List<String> DEFAULT_INVERTED_INDEX_COLUMNS
+ = Lists.newArrayList("FlightNum", "Origin", "Quarter");
+ private static final List<String> DEFAULT_BLOOM_FILTER_COLUMNS =
Lists.newArrayList("FlightNum", "Origin");
+ private static final List<String> DEFAULT_RANGE_INDEX_COLUMNS =
Lists.newArrayList("Origin");
Review Comment:
Yes, the range index list is mutated when timestamp indexes are added. The
bloom filter change is not needed, but given we are used to modify these lists,
it is more correct to make them mutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
