gortiz commented on code in PR #14690:
URL: https://github.com/apache/pinot/pull/14690#discussion_r1900115198


##########
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java:
##########
@@ -344,6 +347,17 @@ public static void 
rewriteQueryContextWithHints(QueryContext queryContext, Index
     selectExpressions.replaceAll(
         expression -> overrideWithExpressionHints(expression, indexSegment, 
expressionOverrideHints));
 
+    List<Pair<AggregationFunction, FilterContext>> filtAggrFuns = 
queryContext.getFilteredAggregationFunctions();
+    if (filtAggrFuns != null) {
+      for (Pair<AggregationFunction, FilterContext> 
filteredAggregationFunction : filtAggrFuns) {
+        FilterContext right = filteredAggregationFunction.getRight();
+        if (right != null) {
+          Predicate predicate = right.getPredicate();
+          predicate.setLhs(overrideWithExpressionHints(predicate.getLhs(), 
indexSegment, expressionOverrideHints));
+        }
+      }
+    }

Review Comment:
   test timestampIndexSubstitutedInAggregateFilter already tested this code in 
MME. I've just added the same test class for SSE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to