yashmayya commented on code in PR #14690:
URL: https://github.com/apache/pinot/pull/14690#discussion_r1900770199
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestVisitor.java:
##########
@@ -240,4 +250,14 @@ private boolean visit(PlanNode node,
ServerPlanRequestContext context) {
node.visit(this, context);
return context.getLeafStageBoundaryNode() == null;
}
+
+ private void applyTimestampIndex(Expression expression, PinotQuery
pinotQuery) {
+ RequestUtils.applyTimestampIndex(expression, pinotQuery);
+ Function functionCall = expression.getFunctionCall();
+ if (expression.isSetFunctionCall()) {
+ for (Expression operand : functionCall.getOperands()) {
+ applyTimestampIndex(operand, pinotQuery);
+ }
+ }
+ }
Review Comment:
> Yes, it is a bit strange. That is the way V1 does it
In v1, the broker only adds the expression override hints if there is an
appropriately configured timestamp index right?
https://github.com/apache/pinot/blob/397fd983088f174137dac5dd6089fbcf3b6ac741/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java#L950-L953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
