yashmayya commented on code in PR #14690:
URL: https://github.com/apache/pinot/pull/14690#discussion_r1903695411
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestVisitor.java:
##########
@@ -240,4 +250,14 @@ private boolean visit(PlanNode node,
ServerPlanRequestContext context) {
node.visit(this, context);
return context.getLeafStageBoundaryNode() == null;
}
+
+ private void applyTimestampIndex(Expression expression, PinotQuery
pinotQuery) {
+ RequestUtils.applyTimestampIndex(expression, pinotQuery);
+ Function functionCall = expression.getFunctionCall();
+ if (expression.isSetFunctionCall()) {
+ for (Expression operand : functionCall.getOperands()) {
+ applyTimestampIndex(operand, pinotQuery);
+ }
+ }
+ }
Review Comment:
Answering my own question, in v2 the expression override won't be applied on
the server side due to the check here -
https://github.com/apache/pinot/blob/0e915edc0379e48e1c18a4f11913d9ac275f1756/pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java#L395-L396
I suppose this isn't ideal since in v1 we're only adding the expression
override hint to the query when there is an appropriate timestamp index
configured, but I've verified that things work as expected regardless due to
the server side checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
