gortiz commented on code in PR #14797:
URL: https://github.com/apache/pinot/pull/14797#discussion_r1915344916
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotJoinExchangeNodeInsertRule.java:
##########
@@ -54,10 +54,15 @@ public void onMatch(RelOptRuleCall call) {
JoinInfo joinInfo = join.analyzeCondition();
RelNode newLeft;
RelNode newRight;
- if (PinotHintOptions.JoinHintOptions.useLookupJoinStrategy(join)) {
+ String joinStrategyHint =
PinotHintOptions.JoinHintOptions.getJoinStrategyHint(join);
+ if
(PinotHintOptions.JoinHintOptions.useLookupJoinStrategy(joinStrategyHint)) {
Review Comment:
nit: what about having a `PinotHintOptions.JoinHintOptions.getJoinStrategy`
that returns an enum we can use in a switch here? We expect to add at least 3
new extra strategies (listed in https://github.com/apache/pinot/issues/14518,
including random + broadcast right now cannot be specified), so the switch
syntax may be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
