siddharthteotia commented on PR #14797: URL: https://github.com/apache/pinot/pull/14797#issuecomment-2591791730
I think I had given some feedback on the naming thing long time ago when Multi Stage engine was being developed. I can't seem to find the thread now. Ideally (this is how more feature complete engines typically do), there is a clear distinction between an EXCHANGE type and the implementation of physical operator. In this case: Exchange types can be - BROADCAST - HASH_PARTITION (like Spark shuffle) - ROUND_ROBIN - SEND_TO_SINGLE Exchange itself is an implemented as a pair operator: - Sender operator as the root operator in the sender stage (downstream) - Receiver operator as the leaf operator in the receiver stage (upstream) Regardless of the exchange, there is some processing done in the receiver stage after the exchange (between 2 stages). In this case, it will be JOIN - Logical Operation - JOIN - Exchange type - BROADCAST - Phsyical operation (depending on planner / optimizer) - Hash, Sort-Merge, NLJ etc With that being said, BROADCAST is NOT A JOIN Strategy. It is an exchange type (e.g an exchange between two Major Fragments in Presto / Trino). So, we should try to build this clear distinction both in code and design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
