bziobrowski commented on code in PR #14797:
URL: https://github.com/apache/pinot/pull/14797#discussion_r1915386396
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/InStageStatsTreeBuilder.java:
##########
@@ -138,11 +138,11 @@ public ObjectNode visitFilter(FilterNode node, Void
context) {
@Override
public ObjectNode visitJoin(JoinNode node, Void context) {
- if (node.getJoinStrategy() == JoinNode.JoinStrategy.HASH) {
- return recursiveCase(node, MultiStageOperator.Type.HASH_JOIN);
- } else {
- assert node.getJoinStrategy() == JoinNode.JoinStrategy.LOOKUP;
+ if (node.getJoinStrategy() == JoinNode.JoinStrategy.LOOKUP) {
return recursiveCase(node, MultiStageOperator.Type.LOOKUP_JOIN);
+ } else {
+ // TODO: Consider renaming this operator type. It handles multiple join
strategies.
Review Comment:
I agree that we should separate the type of join and the type of
distribution/shuffle. The latter is not unique to joins and could also be used
in e.g. aggregations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
