[ 
https://issues.apache.org/jira/browse/PIRK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401267#comment-15401267
 ] 

ASF GitHub Bot commented on PIRK-36:
------------------------------------

Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/38#discussion_r72907964
  
    --- Diff: src/test/java/test/wideskies/standalone/StandaloneTest.java ---
    @@ -49,6 +51,12 @@
     
       public StandaloneTest() throws Exception
       {
    +    // Reset the schema properties and registries
    +    DataSchemaRegistry.clearRegistry();
    +    QuerySchemaRegistry.clearRegistry();
    +    SystemConfiguration.setProperty("data.schemas", "none");
    +    SystemConfiguration.setProperty("query.schemas", "none");
    --- End diff --
    
    How about moving this code to setUp() or Before() method ?


> Ensure Schema Properties and Registries are Reset at the Beginning of 
> Relevant Tests
> ------------------------------------------------------------------------------------
>
>                 Key: PIRK-36
>                 URL: https://issues.apache.org/jira/browse/PIRK-36
>             Project: PIRK
>          Issue Type: Bug
>            Reporter: Ellison Anne Williams
>            Assignee: Ellison Anne Williams
>
> Ensure that schema and registry properties are reset at the beginning of 
> relevant tests - QueryParserUtilsTest and StandaloneTest. A hotfix of this 
> nature was completed for QueryParserUtilsTest to fix a jenkins build issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to