[
https://issues.apache.org/jira/browse/PIRK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401324#comment-15401324
]
ASF GitHub Bot commented on PIRK-36:
------------------------------------
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/38#discussion_r72909436
--- Diff: src/test/java/test/general/PartitionUtilsTest.java ---
@@ -39,7 +40,8 @@
{
private static final Logger logger =
LoggerFactory.getLogger(PartitionUtilsTest.class);
- public PartitionUtilsTest()
+ @BeforeClass
+ public static void setup()
{
PrimitiveTypePartitioner primitivePartitioner = new
PrimitiveTypePartitioner();
}
--- End diff --
This block of code can be removed, this instance of primitivePartitioner is
not used in any of the tests.
> Ensure Schema Properties and Registries are Reset at the Beginning of
> Relevant Tests
> ------------------------------------------------------------------------------------
>
> Key: PIRK-36
> URL: https://issues.apache.org/jira/browse/PIRK-36
> Project: PIRK
> Issue Type: Bug
> Reporter: Ellison Anne Williams
> Assignee: Ellison Anne Williams
>
> Ensure that schema and registry properties are reset at the beginning of
> relevant tests - QueryParserUtilsTest and StandaloneTest. A hotfix of this
> nature was completed for QueryParserUtilsTest to fix a jenkins build issue.
> Also moving test constructors to @BeforeClass setup() methods and adding
> @AfterClass teardown() methods, as appropriate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
