[ 
https://issues.apache.org/jira/browse/PIRK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401328#comment-15401328
 ] 

ASF GitHub Bot commented on PIRK-36:
------------------------------------

Github user ellisonanne commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/38#discussion_r72909520
  
    --- Diff: src/test/java/test/wideskies/standalone/StandaloneTest.java ---
    @@ -45,10 +49,17 @@
     
       private static final String STOPLIST_FILE = "testStopListFile";
     
    -  private String stopListFileProp = null;
    +  private static String stopListFileProp = null;
     
    -  public StandaloneTest() throws Exception
    +  @BeforeClass
    +  public static void setup() throws Exception
       {
    +    // Reset the schema properties and registries
    +    DataSchemaRegistry.clearRegistry();
    +    QuerySchemaRegistry.clearRegistry();
    --- End diff --
    
    clear before the tests - clean up after the tests


> Ensure Schema Properties and Registries are Reset at the Beginning of 
> Relevant Tests
> ------------------------------------------------------------------------------------
>
>                 Key: PIRK-36
>                 URL: https://issues.apache.org/jira/browse/PIRK-36
>             Project: PIRK
>          Issue Type: Bug
>            Reporter: Ellison Anne Williams
>            Assignee: Ellison Anne Williams
>
> Ensure that schema and registry properties are reset at the beginning of 
> relevant tests - QueryParserUtilsTest and StandaloneTest. A hotfix of this 
> nature was completed for QueryParserUtilsTest to fix a jenkins build issue.
> Also moving test constructors to @BeforeClass setup() methods and adding 
> @AfterClass teardown() methods, as appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to