MonkeyCanCode opened a new pull request, #227: URL: https://github.com/apache/polaris/pull/227
# Description As https://github.com/apache/polaris/pull/114 added support for building the project with eclipselink via optional flag, this PR is add the same support via optional command line argument to `run.sh` when using mini-deployment locally. ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation update - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? Default: ``` yong@DESKTOP:~/polaris(optional_eclipselink)$ bash run.sh Building Kind Registry... ... Creating cluster "kind" ... ... Building polaris image with ECLIPSELINK=false... ... Applying Kubernetes manifests... namespace/polaris created deployment.apps/polaris-deployment created service/polaris-service created ``` With optional command line argument: ``` yong@DESKTOP:~/polaris(optional_eclipselink)$ bash run.sh -e true Building Kind Registry... ... Creating cluster "kind" ... ... Building polaris image with ECLIPSELINK=true... ... Applying Kubernetes manifests... namespace/polaris created deployment.apps/polaris-deployment created service/polaris-service created ``` Helper: ``` xxx@DESKTOP:~/polaris(optional_eclipselink)$ bash run.sh -h Usage: run.sh [-e true|false] [-h] -e Set the ECLIPSELINK flag (default: false) -h Display this help message ``` # Checklist: Please delete options that are not relevant. - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
