eric-maynard commented on code in PR #227:
URL: https://github.com/apache/polaris/pull/227#discussion_r1736749613
##########
run.sh:
##########
@@ -21,20 +21,51 @@
# Runs Polaris as a mini-deployment locally. Creates two pods that bind
themselves to port 8181.
-CURRENT_DIR=$(pwd)
+# Initialize variables
+ECLIPSELINK="false" # Default value
-# deploy the registry
+# Function to display usage information
+usage() {
+ echo "Usage: $0 [-e true|false] [-h]"
+ echo " -e Set the ECLIPSELINK flag (default: false)"
+ echo " -h Display this help message"
+ exit 1
+}
Review Comment:
This change is one I'm a little unsure about. Things like metastore manager
and callcontext resolver are designed to be pluggable and discoverable by
DropWizard.
I'm worried about the precedent this sets and whether we would want to add
all these as myriad options here. The script might get quite complicated in
order to cover every combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
