MonkeyCanCode commented on code in PR #227:
URL: https://github.com/apache/polaris/pull/227#discussion_r1736997205
##########
run.sh:
##########
@@ -21,20 +21,51 @@
# Runs Polaris as a mini-deployment locally. Creates two pods that bind
themselves to port 8181.
-CURRENT_DIR=$(pwd)
+# Initialize variables
+ECLIPSELINK="false" # Default value
-# deploy the registry
+# Function to display usage information
+usage() {
+ echo "Usage: $0 [-e true|false] [-h]"
+ echo " -e Set the ECLIPSELINK flag (default: false)"
+ echo " -h Display this help message"
+ exit 1
+}
Review Comment:
@eric-maynard updated with arbitrary build arg support. Please take another
look when you get a chance.
Helper message:
```
Usage: run.sh [-b build-arg1=value1,build-arg2=value2,...] [-h]
-b Pass a set of arbitrary build arguments to docker build, separated
by commas
-h Display this help message
```
Default run:
```
bash run.sh
```
Arbitrary build arg run:
```
bash run.sh -b ECLIPSELINK=true
# sample output:
# Building polaris image with build arguments: --build-arg ECLIPSELINK=true
```
Arbitrary build args run:
```
bash run.sh -b ECLIPSELINK=true,RANDOM=true
# sample output:
# Building polaris image with build arguments: --build-arg ECLIPSELINK=true
--build-arg RANDOM=true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
