eric-maynard commented on code in PR #276:
URL: https://github.com/apache/polaris/pull/276#discussion_r1752911429
##########
polaris-service/src/main/java/org/apache/polaris/service/config/PolarisApplicationConfig.java:
##########
@@ -146,6 +147,15 @@ public void setFeatureConfiguration(Map<String, Object>
featureConfiguration) {
this.configurationStore = new
DefaultConfigurationStore(featureConfiguration);
}
+ @JsonProperty("maxDocumentBytes")
+ public void setMaxDocumentBytes(long maxDocumentBytes) {
+ this.maxDocumentBytes = maxDocumentBytes;
+ }
+
+ public long getMaxDocumentBytes() {
+ return maxDocumentBytes;
+ }
Review Comment:
I also find 0-as-unlimited a little confusing. I agree that if we make the
default -1 it might imply that 0 is different from -1, but I also think a
default of 0 is going to raise some questions.
Maybe we should just disallow 0, since `StreamReadConstraints` doesn't
support what 0 would intuitively mean ("reject all requests")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
