flyrain commented on code in PR #276:
URL: https://github.com/apache/polaris/pull/276#discussion_r1757704877
##########
polaris-service/src/main/java/org/apache/polaris/service/config/PolarisApplicationConfig.java:
##########
@@ -146,6 +149,23 @@ public void setFeatureConfiguration(Map<String, Object>
featureConfiguration) {
this.configurationStore = new
DefaultConfigurationStore(featureConfiguration);
}
+ @JsonProperty("maxRequestBodyBytes")
+ public void setMaxRequestBodyBytes(long maxRequestBodyBytes) {
+ if (maxRequestBodyBytes == 0) {
Review Comment:
Should we consider throwing an exception when the configured value for
maxRequestBodyBytes is less than -1 (e.g., -2, -100)? While the underlying
library can technically handle these values, I believe we should restrict any
negative number except for -1, which is already treated as "unlimited." This is
consistent with our approach of throwing an exception for a value of 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
