andrew4699 commented on code in PR #276:
URL: https://github.com/apache/polaris/pull/276#discussion_r1757668721
##########
polaris-service/src/main/java/org/apache/polaris/service/config/PolarisApplicationConfig.java:
##########
@@ -146,6 +147,15 @@ public void setFeatureConfiguration(Map<String, Object>
featureConfiguration) {
this.configurationStore = new
DefaultConfigurationStore(featureConfiguration);
}
+ @JsonProperty("maxDocumentBytes")
+ public void setMaxDocumentBytes(long maxDocumentBytes) {
+ this.maxDocumentBytes = maxDocumentBytes;
+ }
+
+ public long getMaxDocumentBytes() {
+ return maxDocumentBytes;
+ }
Review Comment:
Ok I updated it to default to -1, explained what -1 is, and restricted 0
with an exception/useful comment. I agree that -1 is a better indicator of "no
limit" and restricting 0 solves some ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
