ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r229598240
########## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/BackedInputStream.java ########## @@ -18,9 +18,12 @@ */ package org.apache.bookkeeper.mledger.offload.jcloud; -import java.io.InputStream; import java.io.IOException; +import java.io.InputStream; +/** Review comment: I'm not saying these changes are wrong. But they're in the wrong PR. This PR is 1500+ lines long. There are substantive code changes in it and stuff that normally could be waved through with a quick glance. But given that there are some real changes, all 1500 lines of change must be looked at carefully. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
