ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r229776075
########## File path: tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/BlobStoreTestBase.java ########## @@ -26,9 +28,12 @@ import org.testng.annotations.AfterMethod; import org.testng.annotations.BeforeMethod; +import lombok.extern.slf4j.Slf4j; + +@Slf4j Review comment: New code should, of course, fit the checkstyle. The issue was in files that would otherwise be untouched. For this patch, it's fine, there are other BC issues which are more important. The issue I have with unrelated changes in general though is that they make an already large patch bigger and that not only means it takes longer to review, but it takes longer to submit. I'd really love to do an analysis someday to see PR LOC vs time on the review queue. I had one myself recently that was at the 1500 mark, unfortunately, at it took 2.5 months to merge. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
