sijie commented on a change in pull request #3168: Refactor api commands
URL: https://github.com/apache/pulsar/pull/3168#discussion_r243146237
##########
File path:
pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SinkApiV2ResourceTest.java
##########
@@ -251,14 +273,19 @@ public void testRegisterSinkMissingPackageDetails()
throws IOException {
topicsToSerDeClassName,
null,
parallelism,
- null,
- "zip file is empty");
+ null
+ );
+ } catch (RestException re){
+ assertEquals(re.getResponse().getStatusInfo(),
Response.Status.BAD_REQUEST);
+ throw re;
+ }
}
- @Test
+ @Test(expectedExceptions = RestException.class,
expectedExceptionsMessageRegExp = "Failed to extract sink class from archive")
Review comment:
keep all assertions in one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
