sijie commented on a change in pull request #3168: Refactor api commands
URL: https://github.com/apache/pulsar/pull/3168#discussion_r243461521
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/SinkApiV2Resource.java
##########
@@ -133,42 +130,42 @@ public Response getSinkInfo(final @PathParam("tenant")
String tenant,
@Produces(MediaType.APPLICATION_JSON)
@Path("/{tenant}/{namespace}/{sinkName}/status")
public SinkStatus getSinkStatus(final @PathParam("tenant") String tenant,
- final @PathParam("namespace") String
namespace,
- final @PathParam("sinkName") String
sinkName) throws IOException {
+ final @PathParam("namespace") String
namespace,
+ final @PathParam("sinkName") String
sinkName) throws IOException {
return sink.getSinkStatus(tenant, namespace, sinkName,
uri.getRequestUri());
}
@GET
@Path("/{tenant}/{namespace}")
- public Response listSink(final @PathParam("tenant") String tenant,
- final @PathParam("namespace") String namespace) {
+ public List<String> listSink(final @PathParam("tenant") String tenant,
Review comment:
this is returning `List<String>` instead of `Response`. doesn't it break the
BC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
