sijie commented on a change in pull request #3168: Refactor api commands
URL: https://github.com/apache/pulsar/pull/3168#discussion_r243145664
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinkBase.java
##########
@@ -85,15 +85,15 @@ public Response registerSink(final @PathParam("tenant")
String tenant,
})
@Path("/{tenant}/{namespace}/{sinkName}")
@Consumes(MediaType.MULTIPART_FORM_DATA)
- public Response updateSink(final @PathParam("tenant") String tenant,
- final @PathParam("namespace") String namespace,
- final @PathParam("sinkName") String sinkName,
- final @FormDataParam("data") InputStream
uploadedInputStream,
- final @FormDataParam("data")
FormDataContentDisposition fileDetail,
- final @FormDataParam("url") String
functionPkgUrl,
- final @FormDataParam("sinkConfig") String
sinkConfigJson) {
+ public void updateSink(final @PathParam("tenant") String tenant,
Review comment:
but this is a breaking change no? How can old pulsar admin clients talk to
new broker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
