hangc0276 commented on a change in pull request #14147:
URL: https://github.com/apache/pulsar/pull/14147#discussion_r800725537
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -329,46 +329,78 @@
doc = "Name of the cluster to which this broker belongs to"
)
private String clusterName;
+
@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
doc = "The maximum number of tenants that each pulsar cluster can
create."
+ "This configuration is not precise control, in a concurrent
scenario, the threshold will be exceeded."
)
private int maxTenants = 0;
+
@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
doc = "Enable cluster's failure-domain which can distribute brokers
into logical region"
)
private boolean failureDomainsEnabled = false;
+
+ @Deprecated
@FieldContext(
category = CATEGORY_SERVER,
- doc = "ZooKeeper session timeout in milliseconds"
+ doc = "ZooKeeper session timeout in milliseconds. "
+ + "@deprecated - Use metadataStoreSessionTimeoutMillis
instead."
)
private long zooKeeperSessionTimeoutMillis = 30000;
+
+ @Deprecated
@FieldContext(
category = CATEGORY_SERVER,
- doc = "ZooKeeper operation timeout in seconds"
+ doc = "ZooKeeper operation timeout in seconds. "
+ + "@deprecated - Use metadataStoreOperationTimeoutSeconds
instead."
)
private int zooKeeperOperationTimeoutSeconds = 30;
+
+ @Deprecated
@FieldContext(
category = CATEGORY_SERVER,
- doc = "ZooKeeper cache expiry time in seconds"
+ doc = "ZooKeeper cache expiry time in seconds. "
Review comment:
You'd better use `deprecated = true` in fieldContext instead of doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
