nicoloboschi commented on a change in pull request #14147:
URL: https://github.com/apache/pulsar/pull/14147#discussion_r800773690



##########
File path: 
pulsar-broker-common/src/test/java/org/apache/pulsar/common/configuration/PulsarConfigurationLoaderTest.java
##########
@@ -152,6 +159,25 @@ public void testPulsarConfiguraitonComplete() throws 
Exception {
         }
     }
 
+    @Test
+    public void testBackwardCompatibility() throws IOException {
+        File testConfigFile = new File("tmp." + System.currentTimeMillis() + 
".properties");
+        if (testConfigFile.exists()) {
+            testConfigFile.delete();
+        }
+        try (PrintWriter printWriter = new PrintWriter(new 
OutputStreamWriter(new FileOutputStream(testConfigFile)))) {
+            printWriter.println("zooKeeperSessionTimeoutMillis=60");

Review comment:
       can you add another test where the configuration contains both 
zooKeeper* and metadataStore* properties ? 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to