Jason918 commented on a change in pull request #14147:
URL: https://github.com/apache/pulsar/pull/14147#discussion_r801427225
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2632,4 +2667,46 @@ public SchemaCompatibilityStrategy
getSchemaCompatibilityStrategy() {
}
return schemaCompatibilityStrategy;
}
+
+ @Deprecated
+ public void setZooKeeperSessionTimeoutMillis(long
zooKeeperSessionTimeoutMillis) {
Review comment:
Does this mean `ZooKeeperSessionTimeoutMillis` just has higher priority
than `MetadataStoreSessionTimeoutMillis` when they both exists in "broker.conf"
?
Since `getZooKeeperSessionTimeoutMillisCan` won't be used again, can we keep
all logic in `getMetadataStoreSessionTimeoutMillis`, and keep the set method as
default? like
```
public long getMetadataStoreSessionTimeoutMillis() {
if (zooKeeperSessionTimeoutMillis > 0) return
zooKeeperSessionTimeoutMillis; //it have higher priority
return metadataStoreSessionTimeoutMillis;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
