merlimat commented on a change in pull request #14176:
URL: https://github.com/apache/pulsar/pull/14176#discussion_r801954176
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -77,6 +78,8 @@
protected AbstractMetadataStore() {
this.executor = Executors
.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("metadata-store"));
+ this.listenerExecutor = Executors
+ .newSingleThreadScheduledExecutor(new
DefaultThreadFactory("metadata-store-listener"));
Review comment:
I'm not sure this is the right approach because it just moves the
problem to a different thread. Instead we should make sure that no blocking
calls are happening from the callbacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
