michaeljmarshall commented on a change in pull request #14176:
URL: https://github.com/apache/pulsar/pull/14176#discussion_r801966315
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -77,6 +78,8 @@
protected AbstractMetadataStore() {
this.executor = Executors
.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("metadata-store"));
+ this.listenerExecutor = Executors
+ .newSingleThreadScheduledExecutor(new
DefaultThreadFactory("metadata-store-listener"));
Review comment:
Thanks for that reference Matteo. Is there any value in adding an extra
thread just in case a blocking method is inadvertently added back onto this
calling thread? The risk seems high, considering we'd be blocking the zk
notification handling thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
