Jason918 commented on a change in pull request #14176:
URL: https://github.com/apache/pulsar/pull/14176#discussion_r802234696
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -192,7 +195,7 @@ public void registerListener(Consumer<Notification>
listener) {
});
return null;
- }, executor);
+ }, listenerExecutor);
Review comment:
I think this would introduce a lot of wired race conditions. Some of our
current implementations relay on this single thread to keep data consistence
and thread safe, like the `existsCache` and `childrenCache`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
