[GitHub] [pulsar] ethqunzhong commented on a change in pull request #14200: Broker: support dynamic update log level at runtime

Wed, 16 Feb 2022 00:07:42 -0800 


ethqunzhong commented on a change in pull request #14200:
URL: https://github.com/apache/pulsar/pull/14200#discussion_r807648147



##########
File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -176,6 +176,20 @@ void run() throws Exception {
         }
     }
 
+    @Parameters(commandDescription = "Update dynamic log4j2 logger level in 
runtime by classname.")
+    private class UpdateLoggerLevelCmd extends CliCommand {

Review comment:
       🤔 Maybe not.
   in product environment, `authenticationEnabled = true` as usual ,so only 
developers or admin can do this. 
   in addition, user call this request will mark the broker ip in log as follow:
   <img width="1075" alt="image" 
src="https://user-images.githubusercontent.com/16517186/154221713-efb4d2d2-5a79-4d47-adf6-514fdf70c957.png";>
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to