ethqunzhong commented on a change in pull request #14200:
URL: https://github.com/apache/pulsar/pull/14200#discussion_r807897213
##########
File path: conf/log4j2.yaml
##########
@@ -134,7 +134,6 @@ Configuration:
additivity: true
AppenderRef:
- ref: "${sys:pulsar.log.appender}"
- level: "${sys:pulsar.log.level}"
Review comment:
> User may already have set `pulsar.log.level=warn` in their deployment.
Will this PR change the settings?
i have a test
if User set `pulsar.log.level=warn` in their deployment while starting
service.
this PR will not change the settings , all loggers's level is `warn`,
meanwhile , the PR featrue also works.
> ~~level: "${sys:pulsar.log.level}"~~
this line config is redundant and will disturb the programmatically way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
