[GitHub] [pulsar] ethqunzhong commented on a change in pull request #14200: Broker: support dynamic update log level at runtime

[GitBox]

ethqunzhong commented on a change in pull request #14200:
URL: https://github.com/apache/pulsar/pull/14200#discussion_r812518287



##########
File path: conf/log4j2.yaml
##########
@@ -134,7 +134,6 @@ Configuration:
       additivity: true
       AppenderRef:
         - ref: "${sys:pulsar.log.appender}"
-          level: "${sys:pulsar.log.level}"

Review comment:
       i have a test in standalone mode after removed this line. 
   1. `pulsar.log.level` set by ENV property PULSAR_LOG_LEVEL in pulsar_env.sh 
to `warn`
   <img width="224" alt="image" 
src="https://user-images.githubusercontent.com/16517186/155252415-39f73dfd-4d33-466b-872c-3fe71fb5e395.png";>
   2. then start pulsar service in standalone mode. the service log level is 
warn, worked as desired. 
   <img width="1066" alt="image" 
src="https://user-images.githubusercontent.com/16517186/155252639-87e46c42-0106-4ca1-9de4-4c6168b23c9c.png";>
   3. then run cmd `bin/pulsar-admin brokers update-logger-level --classname 
org.apache.zookeeper.server.FinalRequestProcessor --level debug` to validation 
feature in this PR. workd as desired.
   <img width="1076" alt="image" 
src="https://user-images.githubusercontent.com/16517186/155252852-e9b7ccb1-740c-419f-9f67-4fd8f2072ae9.png";>
   
   so remove this line would not invalidate user's previous setting (set by ENV 
property `PULSAR_LOG_LEVEL` in pulsar_env.sh
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org