BewareMyPower commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r821802554
##########
File path: pulsar-client-cpp/include/pulsar/MessageId.h
##########
@@ -28,6 +28,7 @@
namespace pulsar {
class MessageIdImpl;
+typedef std::shared_ptr<MessageIdImpl> MessageIdImplPtr;
Review comment:
I mean the headers under `include/pulsar/` are exposed to users. It's
not a good manner to introduce a new `typedef` in these headers. You can add
the common `typedef`s to `lib/xxx.h`, which is not exposed to users.
BTW, I see the duplicated `typedef` in `ChunkMessageIdImpl.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
