BewareMyPower commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r827584377
##########
File path: pulsar-client-cpp/lib/OpSendMsg.h
##########
@@ -25,9 +25,31 @@
#include "TimeUtils.h"
#include "MessageImpl.h"
+#include "ChunkMessageIdImpl.h"
+#include "ProducerImpl.h"
Review comment:
```suggestion
```
The Windows build failure is caused by the recyclic includes. Here in
`OpSendMsg.h`, there is a `#include "ProducerImpl.h"`. However, in
`ProducerImpl.h`, there is a `#include "OpSendMsg.h"`. I'm not sure why other
compilers can compile it successfully. We already have the forward declaration
of `ProducerImpl`, there is no need to include the `ProducerImpl.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
