BewareMyPower commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r825641966
##########
File path: pulsar-client-cpp/lib/ConsumerImpl.cc
##########
@@ -1229,7 +1244,17 @@ void ConsumerImpl::seekAsync(const MessageId& msgId,
ResultCallback callback) {
LOG_DEBUG(getName() << " Sending seek Command for Consumer - " <<
getConsumerId() << ", requestId - "
<< requestId);
Future<Result, ResponseData> future =
- cnx->sendRequestWithId(Commands::newSeek(consumerId_, requestId,
msgId), requestId);
+ msgId.isChunkMessageid()
+ ? cnx->sendRequestWithId(
+ Commands::newSeek(consumerId_, requestId,
+
std::dynamic_pointer_cast<ChunkMessageIdImpl>(msgId.impl_)
+ ->getFirstChunkMessageIdImpl()
Review comment:
BTW, do we need to expose the `isChunkMessageid()` to users? Even if the
user knew the message ID is a chunked message ID by calling
`isChunkMessageid()`, there is no way to get the underlying
`ChunkMessageIdImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
