A-Wanderer commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r832018914



##########
File path: pulsar-client-cpp/lib/ConsumerImpl.cc
##########
@@ -1229,7 +1244,17 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, 
ResultCallback callback) {
         LOG_DEBUG(getName() << " Sending seek Command for Consumer - " << 
getConsumerId() << ", requestId - "
                             << requestId);
         Future<Result, ResponseData> future =
-            cnx->sendRequestWithId(Commands::newSeek(consumerId_, requestId, 
msgId), requestId);
+            msgId.isChunkMessageid()
+                ? cnx->sendRequestWithId(
+                      Commands::newSeek(consumerId_, requestId,
+                                        
std::dynamic_pointer_cast<ChunkMessageIdImpl>(msgId.impl_)
+                                            ->getFirstChunkMessageIdImpl()

Review comment:
       OK, I have deleted all exposed `isChunkMessageid()` interfaces to 
prevent problems if interface changes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to