A-Wanderer commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r832547352
##########
File path: pulsar-client-cpp/lib/Commands.cc
##########
@@ -469,6 +469,19 @@ SharedBuffer Commands::newSeek(uint64_t consumerId,
uint64_t requestId, const Me
return writeMessageWithSize(cmd);
}
+SharedBuffer Commands::newSeek(uint64_t consumerId, uint64_t requestId,
int64_t ledgerId, int64_t entryId) {
+ BaseCommand cmd;
+ cmd.set_type(BaseCommand::SEEK);
+ CommandSeek* commandSeek = cmd.mutable_seek();
+ commandSeek->set_consumer_id(consumerId);
+ commandSeek->set_request_id(requestId);
+
+ MessageIdData& messageIdData = *commandSeek->mutable_message_id();
+ messageIdData.set_ledgerid(ledgerId);
+ messageIdData.set_entryid(entryId);
+ return writeMessageWithSize(cmd);
+}
Review comment:
I delete `newSeek(uint64_t consumerId, uint64_t requestId, int64_t
ledgerId, int64_t entryId)` and then add msgIdImpl check in previous newSeek.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
